-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disallow packed arrays #1372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abejgonzalez
approved these changes
Mar 1, 2023
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
err-code: A436E |
Nevermind. I updated the commit in this PR to point to the latest |
abejgonzalez
force-pushed
the
add-disallowPackedArrays
branch
from
March 2, 2023 17:30
40ec17f
to
af2a146
Compare
Oh, thanks |
Looks like there are issues with more complicated designs? |
…/chipyard into add-disallowPackedArrays
This reverts commit af2a146.
…/chipyard into add-disallowPackedArrays
…/chipyard into add-disallowPackedArrays
nayiri-k
approved these changes
Mar 8, 2023
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
err-code: A8ED6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
disallowPackedArrays
flag back for compatibility with openroad tutorial flow.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?