Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPF Generation #1347

Merged
merged 2 commits into from
Jul 13, 2023
Merged

UPF Generation #1347

merged 2 commits into from
Jul 13, 2023

Conversation

sriramsridhar23
Copy link

@sriramsridhar23 sriramsridhar23 commented Feb 16, 2023

UPF Generation working on current chipyard. Current UPFInputs are based on a 2 core RocketConfig. Using a noop annotation to satisfy requirements for toAnnotation in UPFAspect.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@sriramsridhar23 sriramsridhar23 changed the title UPF Generation working UPF Generation working [ci skip] Feb 22, 2023
@abejgonzalez abejgonzalez changed the title UPF Generation working [ci skip] UPF Generation Mar 6, 2023
@sriramsridhar23
Copy link
Author

@abejgonzalez

@lsteveol
Copy link

Would it be possible to update the docs with usage?

docs/VLSI/Advanced-Usage.rst Outdated Show resolved Hide resolved
docs/VLSI/Advanced-Usage.rst Outdated Show resolved Hide resolved
docs/VLSI/Advanced-Usage.rst Outdated Show resolved Hide resolved
docs/VLSI/Advanced-Usage.rst Show resolved Hide resolved
common.mk Outdated Show resolved Hide resolved
generators/chipyard/src/main/scala/upf/UPFInputs.scala Outdated Show resolved Hide resolved
generators/chipyard/src/main/scala/upf/UPFInputs.scala Outdated Show resolved Hide resolved
generators/chipyard/src/main/scala/upf/UPFGen.scala Outdated Show resolved Hide resolved
@abejgonzalez
Copy link
Contributor

You can ignore the commit-on-master-check error (since you don't modify FireSim)

common.mk Outdated Show resolved Hide resolved
docs/VLSI/Advanced-Usage.rst Show resolved Hide resolved
generators/chipyard/src/main/scala/upf/UPFInputs.scala Outdated Show resolved Hide resolved
generators/chipyard/src/main/scala/upf/UPFInputs.scala Outdated Show resolved Hide resolved
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets hold off on merging this until after the release

common.mk Outdated Show resolved Hide resolved
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez merged commit 5b3335d into main Jul 13, 2023
@jerryz123 jerryz123 deleted the upf branch August 22, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants