Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more minimal firesim configs for testing #1313

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

t14916
Copy link
Contributor

@t14916 t14916 commented Jan 19, 2023

Off of this PR: #1302, I originally tried to put these configs into firesim but I had trouble getting this to work with the build environment, so I'm just going to put these configs here for now since we seem to want them sooner rather than later.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there may be some instability with chipyard/main + firesim at the moment, since the scala2.13 bump was merged into firesim before the chipyard bump was completed.

@t14916
Copy link
Contributor Author

t14916 commented Jan 19, 2023

Do you think these changes will make it into the chipyard bump?

@jerryz123
Copy link
Contributor

Yeah. I'll merge these now. I meant that using latest firesim with latest Chipyard may not work

@jerryz123 jerryz123 merged commit 95f30d0 into main Jan 19, 2023
@jerryz123 jerryz123 deleted the tsondhi/add_more_firesim_conf branch February 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants