Remove conda from build-toolchains-extra.sh #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
reviewed
Oct 23, 2022
build-setup.sh
Outdated
| fi | ||
| PREFIX=$RISCV | ||
| fi | ||
| $RDIR/scripts/build-toolchain-extra.sh $TOOLCHAIN -p $PREFIX |
There was a problem hiding this comment.
What is the use case for skip-toolchain-extra? It might be cleaner to remove this option entirely? Building the toolchain-extra components should be very fast.
There was a problem hiding this comment.
No good reason that I could think of. In the past, I tried to make it so that the build-setup.sh script could opt out of running particular scripts but I agree with you that most people don't mind the extra runtime (and if they do, then they are most likely power users who would like to run the scripts separately).
There was a problem hiding this comment.
Yeah. I'm in favor of just removing the skip-extra case.
abejgonzalez
force-pushed
the
no-conda
branch
from
5dfccec
to
a0ad9d2
Compare
jerryz123
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #1259 to better support non-conda users. Removes conda variables from
build-toolchain-extra.sh.build-setup.shnow needsRISCVdefined if users are skipping conda.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?