Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mm: Fix write-strobe handling for 64B word configurations #1214

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

davidbiancolin
Copy link
Contributor

Not a common configuration. Unless you're doing FPGA stuff.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123
Copy link
Contributor

@abejgonzalez Do you know why this is failing? Doesn't seem to be related to this PR.

@davidbiancolin
Copy link
Contributor Author

I did a ff merge in testchipip so the commit pointed to here is now at the head of master

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI is failing due to another issue.

@jerryz123 jerryz123 merged commit d5a1810 into main Aug 29, 2022
@jerryz123 jerryz123 deleted the mm-strb-fix branch October 1, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants