Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DROMAJO_ROM variable fix #1197

Merged
merged 2 commits into from
Jul 20, 2022
Merged

DROMAJO_ROM variable fix #1197

merged 2 commits into from
Jul 20, 2022

Conversation

jzhou1318
Copy link
Contributor

DROMAJO_ROM needs to point at bootrom.rv64.img which exists at $(base_dir)/generators/testchipip/src/main/resources/testchipip/bootrom/bootrom.rv64.img instead of $(base_dir)/bootrom/bootrom.rv64.img

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jzhou1318 jzhou1318 requested a review from jerryz123 July 13, 2022 17:24
jerryz123
jerryz123 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

abejgonzalez
abejgonzalez requested changes Jul 18, 2022
View reviewed changes
tools/dromajo/dromajo.mk Outdated Show resolved Hide resolved
abejgonzalez
abejgonzalez approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 merged commit 684a02a into main Jul 20, 2022
@mergify mergify bot mentioned this pull request Jul 20, 2022
Merged
@mergify mergify bot added the Backported label Jul 20, 2022
abejgonzalez added a commit that referenced this pull request Jul 21, 2022
@abejgonzalez
Merge pull request #1204 from ucb-bar/mergify/bp/1.6.x/pr-1197
2d6c77a 
DROMAJO_ROM variable fix (backport #1197)
@jerryz123 jerryz123 deleted the bootrom_change branch October 1, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
Backported changelog:fixed Please Backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzhou1318 @abejgonzalez @jerryz123