Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bloop back to sbt plugins. #1167

Merged
merged 1 commit into from
May 17, 2022
Merged

Add bloop back to sbt plugins. #1167

merged 1 commit into from
May 17, 2022

Conversation

davidbiancolin
Copy link
Contributor

@davidbiancolin davidbiancolin commented May 11, 2022 •
edited
Loading

This to support VSCode integration in FireSim and in Chipyard.

See: firesim/firesim#1056

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

abejgonzalez
abejgonzalez approved these changes May 15, 2022
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidbiancolin davidbiancolin merged commit 171ee8b into main May 17, 2022
@davidbiancolin davidbiancolin deleted the readd-bloop branch May 17, 2022 22:25
jerryz123 pushed a commit that referenced this pull request Sep 16, 2022
@davidbiancolin @jerryz123
Add bloop back to sbt plugins. (#1167)
1133cfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
changelog:added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbiancolin @abejgonzalez