Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] fix a few things in domain migration command #5374

Merged
merged 5 commits into from
Aug 9, 2023
Merged

[CLI] fix a few things in domain migration command #5374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7b79a1
[CLI] fix a few things in domain migration command
shijiesheng Aug 8, 2023
81920bd
Merge branch 'master' into cli-flag
shijiesheng Aug 8, 2023
b607975
use current domain frontend
shijiesheng Aug 8, 2023
27f804d
address comments
shijiesheng Aug 8, 2023
aeb355f
refactor and fix one more threadsafety issue
shijiesheng Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tools/cli/app_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ func (m *clientFactoryMock) ServerAdminClient(c *cli.Context) admin.Client {
return m.serverAdminClient
}

func (m *clientFactoryMock) ServerFrontendClientForMigration(c *cli.Context) frontend.Client {
panic("not implemented")
}

func (m *clientFactoryMock) ServerAdminClientForMigration(c *cli.Context) admin.Client {
panic("not implemented")
}

func (m *clientFactoryMock) ElasticSearchClient(c *cli.Context) *elastic.Client {
panic("not implemented")
}
Expand Down
3 changes: 1 addition & 2 deletions tools/cli/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,13 @@ func newDomainCommands() []cli.Command {
newDomainCLI(c, false).DescribeDomain(c)
},
},

{
Name: "migration",
Aliases: []string{"mi"},
Usage: "Migrate existing domain to new domain. This command only validates the settings. It does not perform actual data migration",
Flags: migrateDomainFlags,
Action: func(c *cli.Context) {
newDomainCLI(c, true).MigrateDomain(c)
newDomainMigrationCLIImpl(c).Validation(c)
},
},
}
Expand Down
Loading