[CLI] fix a few things in domain migration command #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasaling
approved these changes
Aug 8, 2023
Shaddoll
reviewed
Aug 8, 2023
| @@ -139,6 +135,31 @@ func (b *clientFactory) ServerAdminClient(c *cli.Context) admin.Client { | |||
| return admin.NewThriftClient(serverAdmin.New(clientConfig)) | |||
| } | |||
|
|
|||
| // ServerFrontendClientForMigration builds a frontend client (based on server side thrift interface) | |||
| func (b *clientFactory) ServerFrontendClientForMigration(c *cli.Context) frontend.Client { | |||
There was a problem hiding this comment.
the code is exactly the same as ServerFrontendClient, should dispatcher be replaced with something else?
There was a problem hiding this comment.
good catch. fixed
Shaddoll
reviewed
Aug 8, 2023
tools/cli/factory.go
Outdated
| // ServerAdminClientForMigration builds an admin client (based on server side thrift interface) | ||
| func (b *clientFactory) ServerAdminClientForMigration(c *cli.Context) admin.Client { | ||
| b.ensureDispatcher(c) | ||
| clientConfig := b.dispatcher.ClientConfig(cadenceFrontendService) |
Shaddoll
reviewed
Aug 8, 2023
| } | ||
|
|
||
| // DEPRECATED don't use, only reserved for backward compatibility purposes | ||
| // NewClientFactory creates a new ClientFactory | ||
| func NewClientFactory() ClientFactory { |
There was a problem hiding this comment.
The method was marked as deprecated, is there a way to not use it?
There was a problem hiding this comment.
it was deprecated in the previous CLI pr but then I realize it should not be deprecated.
Shaddoll
reviewed
Aug 8, 2023
| b.dispatcher = b.newClientDispatcher(c, c.GlobalString(FlagAddress)) | ||
| } | ||
|
|
||
| func (b *clientFactory) ensureDispatcherForMigration(c *cli.Context) { |
There was a problem hiding this comment.
this method is not used anywhere
Shaddoll
approved these changes
Aug 8, 2023
shijiesheng
commented
Aug 9, 2023
| @@ -768,8 +768,8 @@ func newIndefiniteContext(c *cli.Context) (context.Context, context.CancelFunc) | |||
| } | |||
|
|
|||
| func newTimedContext(c *cli.Context, timeout time.Duration) (context.Context, context.CancelFunc) { | |||
| if c.GlobalIsSet(FlagContextTimeout) { | |||
There was a problem hiding this comment.
because this operation is not thread safe, I changed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
add two methods in ClientFactory for migrationThis is needed to be able to use environment flags for internal usage
How did you test it?
Potential risks
No Risk
Release notes
Documentation Changes