-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create TTL in the UpdateWorkflowExecution cycles. #5243
Merged
Merged
Changes from 48 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
9d6a369
Adding TTL to the executions during the updateworkflow step
agautam478 ac5d6b4
Determining TTL duration
agautam478 98869d1
Adding Dynamic Config to TTL
agautam478 b25a168
Merge branch 'master' into updateworkflow
agautam478 9f03e49
Added DC and updated tests
agautam478 82b06e5
Merge branch 'master' into updateworkflow
agautam478 7b21e82
Added the Dynamic config to persistence tests
agautam478 0f2023e
Added updateworkflowTTL unit test
agautam478 68a2b02
Merge branch 'master' into updateworkflow
agautam478 1b55939
Added updateworkflowTTL unit test
agautam478 2d7a4cb
Added updateworkflowTTL unit test
agautam478 95cb954
Added updateworkflowTTL unit test
agautam478 0dd736c
Added updateworkflowTTL unit test
agautam478 d9d6c19
Merge branch 'master' into updateworkflow
agautam478 43ea9b8
Added updateworkflowTTL unit test
agautam478 db60ce0
Added updateworkflowTTL unit test
agautam478 facde95
Added updateworkflowTTL unit test
agautam478 8093616
Added updateworkflowTTL unit test
agautam478 db68b04
Updated the tests with TODO and new checks
agautam478 9444968
Updated the tests with TODO and new checks
agautam478 d8b7493
Updated the tests with a new check
agautam478 aefe10b
Merge branch 'master' into updateworkflow
agautam478 83a49f1
Merge branch 'master' into updateworkflow
agautam478 fcb483b
Merge branch 'master' into updateworkflow
agautam478 33f2cd3
Resolved nit comments
agautam478 b78b80f
Added TODO for flow change
agautam478 fb2db42
Merge branch 'master' into updateworkflow
agautam478 0302ea0
Moved the TTL from Update cycles to the workflow mutation:
agautam478 ab0f84c
Cleaned up the code and fixed minor bugs
agautam478 60b27d0
Merge branch 'master' into updateworkflow
agautam478 8a1933a
Merge branch 'master' into updateworkflow
agautam478 f4d3b50
Resolved comments and updated unit test
agautam478 834b1ed
Merge branch 'master' into updateworkflow
agautam478 229ddcb
Merge branch 'master' into updateworkflow
agautam478 7b6a9eb
Resolved the code comments
agautam478 16f7788
Added comment explaining the cron starttime
agautam478 8291df6
Merge branch 'master' into updateworkflow
agautam478 091baad
Added new unit test for TTL
agautam478 253d158
Added new unit test for TTL
agautam478 c55f175
Merge branch 'master' into updateworkflow
agautam478 ff30f9b
Added new unit test for TTL
agautam478 500aa35
Updated updateworkflow params
agautam478 f0ca8f1
New create and update info
agautam478 11517a2
Add TTL info
agautam478 07ec550
Add TTL check for get workflow
agautam478 9c89bf3
Merge branch 'master' into updateworkflow
agautam478 ca24c56
fixing the primary key bug
agautam478 401636c
Added an insert to enable TTL for the primary keys
agautam478 1c4ac0c
Added close status check to state check
agautam478 9637621
Merge branch 'master' into updateworkflow
agautam478 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this condition doesn't cover all closed workflows https://github.com/uber/cadence/blob/714aec48796b62af163e9d324462a1cc2afb4981/common/persistence/dataManagerInterfaces.go#L129C5-L129C5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should check
state == WorkflowStateCompleted
insteadcadence/common/persistence/dataManagerInterfaces.go
Line 120 in 714aec4