Create TTL in the UpdateWorkflowExecution cycles.

[agautam478]

What changed?
Adding TTL to the CreateWorkflowRequest is not enough because it gets overwritten by the 'UpdateWorkflowRequest' and the final value of the TTL is persisted.
So we reimplemented the code and added TTL into the UpdateworkflowRequest instead.
Supporting document:
https://docs.google.com/document/d/14Bn3W32DdJEP9dVi2MDTyGD0joUG8K_i4wCFEfFZJns/edit?usp=sharing

Why?
Calculate the TTL in the Update Workflow context and update the subsequent queries down the persistence layer. Adding TTL to the CreateWorkflowRequest is not enough because it gets overwritten by the 'UpdateWorkflowRequest' and the TTL is removed. Cassandra does not allow persistence of the TTL on its tables. If you perform an update without TTL then the TTL will be lost. In other words, we had to insert the TTL during the Workflow state update.

Moved the TTL to Workflow mutation

How did you test it?
Tested locally and unit tests.

Potential risks
We might experience data loss if the TTL value is not appropriate or if the TTL accidentally cause data deletion.

Release notes
NA

Documentation Changes
NA

[coveralls]

Pull Request Test Coverage Report for Build 01890345-07e3-4b4f-8663-5aac7638262d

• 51 of 140 (36.43%) changed or added relevant lines in 7 files are covered.
• 78 unchanged lines in 16 files lost coverage.
• Overall coverage decreased (-0.04%) to 57.23%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
common/persistence/persistence-tests/persistenceTestBase.go	0	1	0.0%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go	17	19	89.47%
service/history/execution/mutable_state_builder.go	25	29	86.21%
common/persistence/persistence-tests/executionManagerTest.go	0	82	0.0%

Files with Coverage Reduction	New Missed Lines	%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go	1	74.5%
service/history/execution/context.go	1	69.09%
service/history/queue/timer_queue_processor_base.go	1	77.26%
service/history/queue/transfer_queue_processor_base.go	1	77.62%
common/persistence/sql/common.go	2	50.65%
common/persistence/sql/sqlplugin/mysql/db.go	2	83.33%
service/history/task/transfer_active_task_executor.go	2	72.24%
service/matching/matcher.go	2	90.29%
common/log/tag/tags.go	3	49.04%
service/history/queue/timer_gate.go	3	95.83%

Totals
Change from base Build 0188e07b-5773-43c7-910d-9b29e3a515c6:	-0.04%
Covered Lines:	87094
Relevant Lines:	152183

---

💛 - Coveralls

[Shaddoll]

I think a not-found error should be expected.

[Shaddoll]

this condition doesn't cover all closed workflows https://github.com/uber/cadence/blob/714aec48796b62af163e9d324462a1cc2afb4981/common/persistence/dataManagerInterfaces.go#L129C5-L129C5

[Shaddoll]

I think you should check state == WorkflowStateCompleted instead

cadence/common/persistence/dataManagerInterfaces.go

Line 120 in 714aec4

WorkflowStateCompleted