CDNC-2088 #5094
Merged
CDNC-2088 #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
neil-xie
reviewed
Feb 14, 2023
|
from your note, do you need to add the tag here https://github.com/uber/cadence/blob/master/service/history/task/cross_cluster_task.go#L362 |
|
@neil-xie Yes you are right! Nice catch. I totally missed that one. I've searched all other uses of the metric TaskAttemptTimerPerDomain, and made sure that everything was covered. |
bowenxia
added a commit
to bowenxia/cadence
that referenced
this pull request
Feb 23, 2023
This reverts commit fbe72b3.
bowenxia
added a commit
that referenced
this pull request
Mar 6, 2023
…dy into Attribute for auditing (#5124) * Revert "CDNC-2088 (#5094) Add attempt-count to task processing logs" This reverts commit fbe72b3. * experiment on adding audit info (has errorsgit status) * move AuditInfo into Attr * implement requestBody Struct, implement it using requests, add it into Attribute to use this field for auditing manual accesses * change struct name to be ManualRequestBody to avoid conflict * change any to interface to solve a compiling error * rerun make go-generate && make fmt && make lint && make copyright for auto generated code * change the PII-filtered request to still be a requset instead of a map * add a utility function to check if access is manual, add request body into Attribute * update with make go-generate && make fmt && make lint && make copyright * update comments and naming * change Sprintf to marshal * add error handling for json.marshal, pass it to the caller of SerializeForLogging function * add a new log tag for actor email address * update interface function error handling * pass in a pointer for serialization instead of a struct * delete the isManual checks when creating Attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add AttemptCount into log
Why?
Currently we have metrics for number-of-attempts and have alerts on them, but finding the associated workflows can be tricky due to other logs also existing / temporary issues that self-recover happening all the time.
How did you test it?
Unit test
Potential risks
no
Release notes
Documentation Changes