Skip to content

Commit

Permalink
Revert "CDNC-2088 (#5094) Add attempt-count to task processing logs" (#…
Browse files Browse the repository at this point in the history
…5115)

This reverts commit fbe72b3.
  • Loading branch information
bowenxia authored Feb 23, 2023
1 parent 471cf77 commit e32116d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
4 changes: 2 additions & 2 deletions common/log/tag/tags.go
Original file line number Diff line number Diff line change
Expand Up @@ -591,8 +591,8 @@ func Attempt(attempt int32) Tag {
}

// AttemptCount returns tag for AttemptCount
func AttemptCount(attemptCount int) Tag {
return newInt("attempt-count", attemptCount)
func AttemptCount(attemptCount int64) Tag {
return newInt64("attempt-count", attemptCount)
}

// AttemptStart returns tag for AttemptStart
Expand Down
6 changes: 1 addition & 5 deletions service/history/task/cross_cluster_task.go
Original file line number Diff line number Diff line change
Expand Up @@ -359,11 +359,7 @@ func (t *crossClusterSourceTask) HandleErr(
if attempt > t.maxRetryCount {
t.scope.RecordTimer(metrics.TaskAttemptTimerPerDomain, time.Duration(attempt))
t.logger.Error("Critical error processing task, retrying.",
tag.Error(err),
tag.OperationCritical,
tag.TaskType(t.GetTaskType()),
tag.AttemptCount(t.GetAttempt()),
)
tag.Error(err), tag.OperationCritical, tag.TaskType(t.GetTaskType()))
}
}
}()
Expand Down
1 change: 0 additions & 1 deletion service/history/task/task.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ func (t *taskImpl) HandleErr(
tag.Error(err),
tag.OperationCritical,
tag.TaskType(t.GetTaskType()),
tag.AttemptCount(t.GetAttempt()),
)
}
}
Expand Down

0 comments on commit e32116d

Please sign in to comment.