Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused parameter #4719

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Removed unused parameter #4719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions service/history/execution/state_rebuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ func (r *stateRebuilderImpl) Rebuild(

iter := collection.NewPagingIterator(r.getPaginationFn(
ctx,
baseWorkflowIdentifier,
common.FirstEventID,
baseLastEventID+1,
baseBranchToken,
Expand Down Expand Up @@ -239,7 +238,6 @@ func (r *stateRebuilderImpl) applyEvents(

func (r *stateRebuilderImpl) getPaginationFn(
ctx context.Context,
workflowIdentifier definition.WorkflowIdentifier,
firstEventID int64,
nextEventID int64,
branchToken []byte,
Expand Down
3 changes: 1 addition & 2 deletions service/history/execution/state_rebuilder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ func (s *stateRebuilderSuite) TestPagination() {
firstEventID := common.FirstEventID
nextEventID := int64(101)
branchToken := []byte("some random branch token")
workflowIdentifier := definition.NewWorkflowIdentifier(s.domainID, s.workflowID, s.runID)

event1 := &types.HistoryEvent{
EventID: 1,
Expand Down Expand Up @@ -209,7 +208,7 @@ func (s *stateRebuilderSuite) TestPagination() {
Size: 67890,
}, nil).Once()

paginationFn := s.nDCStateRebuilder.getPaginationFn(context.Background(), workflowIdentifier, firstEventID, nextEventID, branchToken)
paginationFn := s.nDCStateRebuilder.getPaginationFn(context.Background(), firstEventID, nextEventID, branchToken)
iter := collection.NewPagingIterator(paginationFn)

result := []*types.History{}
Expand Down