Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused parameter #4719

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Removed unused parameter #4719

merged 1 commit into from
Feb 1, 2022

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Removed unused parameter

Why?
Not used

How did you test it?

Potential risks

Release notes

Documentation Changes

@vytautas-karpavicius vytautas-karpavicius requested a review from a team January 31, 2022 14:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build b856c0dc-95a4-42f4-ae13-1fb1af0e134b

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 57 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 56.884%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 73.82%
service/history/handler.go 2 48.56%
service/matching/taskListManager.go 2 74.19%
common/types/history.go 4 24.89%
service/history/historyEngine.go 4 71.3%
service/history/task/fetcher.go 4 86.15%
common/cache/lru.go 5 90.73%
common/task/fifoTaskScheduler.go 5 84.54%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
Totals Coverage Status
Change from base Build 8b618f7b-b302-4dd9-814d-21045c97973b: 0.02%
Covered Lines: 83013
Relevant Lines: 145934
💛 - Coveralls

Groxx
Groxx approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vytautas-karpavicius vytautas-karpavicius merged commit b0dff80 into uber:master Feb 1, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the drop-unused-param branch February 1, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groxx Groxx Groxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vytautas-karpavicius @coveralls @Groxx