Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for too frequent domain updates #4711

Merged

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented Jan 26, 2022

What changed?
Updated error message when doing too frequent domain updates.

Why?
Returned cooldown error The domain failovers too frequent. is confusing when performing regular domain update (not a failover)

How did you test it?

Potential risks

Release notes

Documentation Changes

@vytautas-karpavicius vytautas-karpavicius requested a review from a team January 26, 2022 12:48
@vytautas-karpavicius vytautas-karpavicius changed the title Cooldown error should only affect failovers Update error message for too frequent domain updates Jan 26, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 75bd0e2d-1cf3-479c-98ac-1ca9dcab1d50

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 113 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.04%) to 56.903%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
common/cache/lru.go 3 90.73%
service/history/task/fetcher.go 4 86.15%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 55.04%
service/history/shard/context.go 8 66.27%
common/persistence/sql/sqlExecutionStore.go 16 61.45%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 34 83.65%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 40 75.11%
Totals Coverage Status
Change from base Build 0ab6bd73-5539-4a61-9af5-4d81a5f6e93d: -0.04%
Covered Lines: 83009
Relevant Lines: 145879

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius merged commit e27ed80 into uber:master Jan 27, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the failover-cooldown-fix branch January 27, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants