Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message for too frequent domain updates #4711

Merged
merged 4 commits into from
Jan 27, 2022
Merged

Update error message for too frequent domain updates #4711

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6899d7
Cooldown error should only affect failovers
vytautas-karpavicius Jan 26, 2022
79cf2db
Fix error message instead
vytautas-karpavicius Jan 26, 2022
899565c
Merge branch 'master' into failover-cooldown-fix
vytautas-karpavicius Jan 26, 2022
b6b94c9
Merge branch 'master' into failover-cooldown-fix
vytautas-karpavicius Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/domain/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import (
)

var (
errFailoverTooFrequent = &types.ServiceBusyError{Message: "The domain failovers too frequent."}
errDomainUpdateTooFrequent = &types.ServiceBusyError{Message: "Domain update too frequent."}
)

type (
Expand Down Expand Up @@ -511,7 +511,7 @@ func (d *handlerImpl) UpdateDomain(
now := d.timeSource.Now()
// Check the failover cool down time
if lastUpdatedTime.Add(d.config.FailoverCoolDown(info.Name)).After(now) {
return nil, errFailoverTooFrequent
return nil, errDomainUpdateTooFrequent
}

// set the versions
Expand Down