Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record more started time/errors for retried activities #1873

Closed
longquanzheng opened this issue May 17, 2019 · 2 comments · Fixed by #3116
Closed

Record more started time/errors for retried activities #1873

longquanzheng opened this issue May 17, 2019 · 2 comments · Fixed by #3116
Assignees
@emrahs
Labels
customer Feature asks from customer up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute
Milestone
Smaller Tasks

Comments

@longquanzheng
Copy link
Collaborator

Right now we only record the last started time when writing down the started event. This is super confusing for customers even for us.

We don't have to record all of them, but it will be nice to have a limit like at most 5 of them can be recorded down.
@longquanzheng longquanzheng added the customer Feature asks from customer label May 17, 2019
@longquanzheng longquanzheng changed the title Record more started time for retried activities Record more started time/errors for retried activities Jun 14, 2019
@dizUber
Copy link

dizUber commented Jun 14, 2019

During using the Cadence, we found one activity will fail to schedule on all the machines, the last time it fails by timeout. But the failure records in the process will help debugging the issue.

@martinxsliu
Copy link

Hi all, is there any progress on this issue? We're looking at adopting Cadence, in part as a potential replacement for our existing background workers. Currently, if an activity fails and is retried, there is no way to see what the error message is that caused the failure which makes it difficult to debug. This feature is something that comes out of the box with traditional job workers like Sidekiq or Celery.

@martinxsliu martinxsliu mentioned this issue Oct 22, 2019
Closed
@meiliang86 meiliang86 self-assigned this Feb 13, 2020
@meiliang86 meiliang86 added the up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute label Feb 13, 2020
@meiliang86 meiliang86 added this to the Smaller Tasks milestone Feb 13, 2020
@meiliang86 meiliang86 assigned emrahs and unassigned meiliang86 Feb 19, 2020
@emrahs emrahs mentioned this issue Mar 12, 2020
Merged
emrahs added a commit that referenced this issue Mar 13, 2020
@emrahs
Record error info for retried activities (#1873)
3a82e3b 
Exposes the lastFailureReason and lastFailureDetails, which exist in the mutable state, through
the ActivityTaskStartedEvent in the history. The fields were added to ActivityTaskStartedEvent
as part of uber/cadence-idl#15

Resolves: #1873
@emrahs emrahs mentioned this issue Mar 13, 2020
Merged
emrahs added a commit that referenced this issue Mar 20, 2020
@emrahs
Record error info for retried activities (#1873) (#3116)
74c2c69 
* Record error info for retried activities (#1873)

Exposes the lastFailureReason and lastFailureDetails, which exist in the mutable state, through
the ActivityTaskStartedEvent in the history. The fields were added to ActivityTaskStartedEvent
as part of uber/cadence-idl#15

* Add tests to verify error info in retried activities
anish531213 pushed a commit that referenced this issue Apr 10, 2020
@emrahs @anish531213
Record error info for retried activities (#1873) (#3116)
6fb6909 
* Record error info for retried activities (#1873)

Exposes the lastFailureReason and lastFailureDetails, which exist in the mutable state, through
the ActivityTaskStartedEvent in the history. The fields were added to ActivityTaskStartedEvent
as part of uber/cadence-idl#15

* Add tests to verify error info in retried activities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emrahs emrahs

Labels
customer Feature asks from customer up-for-grabs Issues that are good entry points for those new to Cadence that want to contribute
Projects
None yet
Milestone
Smaller Tasks
Development

Successfully merging a pull request may close this issue.

Record error info for retried activities (#1873) uber/cadence
5 participants
@meiliang86 @longquanzheng @emrahs @martinxsliu @dizUber