Add last error related information to ActivityTaskStartedEventAttributes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entAttributes These fields are needed to expose information about the retried activity task execution errors. More details are available at: uber/cadence#187
venkat1109
approved these changes
Mar 12, 2020
vitarb
reviewed
Mar 13, 2020
| @@ -0,0 +1 @@ | |||
| .idea/ | |||
emrahs
added a commit
to uber/cadence
that referenced
this pull request
Mar 13, 2020
Exposes the lastFailureReason and lastFailureDetails, which exist in the mutable state, through the ActivityTaskStartedEvent in the history. The fields were added to ActivityTaskStartedEvent as part of uber/cadence-idl#15 Resolves: #1873
emrahs
added a commit
to uber/cadence
that referenced
this pull request
Mar 20, 2020
* Record error info for retried activities (#1873) Exposes the lastFailureReason and lastFailureDetails, which exist in the mutable state, through the ActivityTaskStartedEvent in the history. The fields were added to ActivityTaskStartedEvent as part of uber/cadence-idl#15 * Add tests to verify error info in retried activities
anish531213
pushed a commit
to uber/cadence
that referenced
this pull request
Apr 10, 2020
* Record error info for retried activities (#1873) Exposes the lastFailureReason and lastFailureDetails, which exist in the mutable state, through the ActivityTaskStartedEvent in the history. The fields were added to ActivityTaskStartedEvent as part of uber/cadence-idl#15 * Add tests to verify error info in retried activities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the fields that are needed to expose information about retried activity task execution errors. See the related Cadence issue for more details: uber/cadence#1873
We had 3 ways to make this change:
I like Option 3 more due to its extensibility but decided to go with Option 1 for sake of consistency with ActivityTaskTimedOutEventAttributes and PendingActivityInfo structs.