Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Improve instructions on fetching flamegraph scripts #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve instructions on fetching flamegraph scripts #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion renderer/flamegraph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ import (
var errNoPerlScript = errors.New("Cannot find flamegraph scripts in the PATH or current " +
"directory. You can download the script at https://github.com/brendangregg/FlameGraph. " +
"These scripts should be added to your PATH or in the directory where go-torch is executed. " +
"Alternatively, you can run go-torch with the --raw flag.")
"Alternatively, you can run go-torch with the --raw flag." +
"Once installed you should have `stackcollapse.pl` and `flamegraph.pl`" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error is getting quite long, should we instead have a link to some markdown file in the repo or a GH wiki page that has more instructions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

"either with or without the `.pl` suffix, in your $PATH.",
)

var (
stackCollapseScripts = []string{"stackcollapse.pl", "./stackcollapse.pl", "./FlameGraph/stackcollapse.pl"}
Expand Down