This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
Improve instructions on fetching flamegraph scripts #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first time I set this up on a new machine it pointed me to the repo, but didn't say which files I needed. So it took some trial and error before I got it working. We should be explicit in what we use.
|
|
|
also @prashantv can we fix the CLA bot here? |
3 similar comments
prashantv
reviewed
Jan 17, 2017
| @@ -30,7 +30,10 @@ import ( | |||
| var errNoPerlScript = errors.New("Cannot find flamegraph scripts in the PATH or current " + | |||
| "directory. You can download the script at https://github.com/brendangregg/FlameGraph. " + | |||
| "These scripts should be added to your PATH or in the directory where go-torch is executed. " + | |||
| "Alternatively, you can run go-torch with the --raw flag.") | |||
| "Alternatively, you can run go-torch with the --raw flag." + | |||
| "Once installed you should have `stackcollapse.pl` and `flamegraph.pl`" + | |||
There was a problem hiding this comment.
This error is getting quite long, should we instead have a link to some markdown file in the repo or a GH wiki page that has more instructions?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time I set this up on a new machine it pointed me to the repo,
but didn't say which files I needed. So it took some trial and error
before I got it working. We should be explicit in what we use.