Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give admins the ability to add trusted sites #1433

Closed
8 tasks done
stbeep1 opened this issue Jan 4, 2021 · 9 comments
Closed
8 tasks done

Give admins the ability to add trusted sites #1433

stbeep1 opened this issue Jan 4, 2021 · 9 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@stbeep1
Copy link

stbeep1 commented Jan 4, 2021

Prerequisites

  • ✔️ I verified that this is not a filter issue
  • ✔️This is not a support issue or a question
  • ✔️I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Just stumbled while implementing policy settings to start pushing out uBO to replace ABP across all our Chromebooks and Windows 10 laptop. With a little fiddling, was able to push multiple settings and the netWhitelist with multiple domains. One question, though, is if there's a way to push out whitelist domains that doesn't replace the user's whitelist settings? When I push out a couple domains via the netWhitelist value, it replaces the entire list rather than appending/updating existing ones.
Also, Sometimes I want to whitelist a website for my users, but I wanted to allow them to whitelist other websites. Currently, the policies that I can config in admin consle we're extremely limited for uBO. Cloud you release more chrome://policy on uBO??

Your environment

  • uBlock Origin version: v1.31.2
  • Browser Name and version: Google Chrome 85
  • Operating System and version: both Windows 10 (2004) and Chrome OS 85.
@uBlock-user uBlock-user added the enhancement New feature or request label Jan 4, 2021
@uBlock-user uBlock-user changed the title [Feature request] Will ublock Origin support more than 1 Admin policies in chrome://policy. ? Will ublock Origin support more than 1 Admin policies in chrome://policy. ? Jan 4, 2021
@stbeep1 stbeep1 changed the title Will ublock Origin support more than 1 Admin policies in chrome://policy. ? Will ublock Origin support more than 1 Admin policies in "chrome://policy" ? Jan 4, 2021
@gorhill
Copy link
Member

gorhill commented Jan 4, 2021

I will try to add support for this today in dev build.

@stbeep1
Copy link
Author

stbeep1 commented Jan 4, 2021

I will try to add support for this today in dev build.

Huge thanks.

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 4, 2021
Related issue:
- uBlockOrigin/uBlock-issues#1433

The new "extraTrustedSiteDirectives" policy is an array
of strings, each of which is parsed as a trusted-site
directive to append to a user's own set of trusted-site
directives at launch time.

The added trusted-site directives will be considered as
part of the default set of directives by uBO.
@gorhill
Copy link
Member

gorhill commented Jan 4, 2021

The new policy is extraTrustedSiteDirectives (available in 1.32.5b4+), an array of strings, each of which must be a valid directive as per documentation.

These extra trusted-site directives are appended to a user's own directives at every launch, and are considered by uBO as default directives, i.e. they will be rendered as such in the editor.

@stbeep1
Copy link
Author

stbeep1 commented Jan 4, 2021

Well the other problem is that even we forced installed uBO via google admin console and pushed out the settings, end users can still change them when they want. I can describe this as 08:00AM we pushed out the settings then users mess around in the settings page, *they can still change the settings unless they reboot their devices. So that, I said it's limited for us. What do you think about that? @gorhill

Side note: uBO is still my still my favourite Chrome extensions since 2015. I am not a uBO haters or any things related to "let uBO moves into business oriented [movement] guy" that kind of thing. As I totally agree the perspective/idea of the uBO team. I enjoy and love using uBO everyday.

@stbeep1
Copy link
Author

stbeep1 commented Jan 4, 2021

@gorhill @uBlock-user Cloud you comments on that please?

Well the other problem is that even we forced installed uBO via google admin console and pushed out the settings, end users can still change them when they want. I can describe this as 08:00AM we pushed out the settings then users mess around in the settings page, *they can still change the settings unless they reboot their devices. So that, I said it's limited for us. What do you think about that?

@gorhill
Copy link
Member

gorhill commented Jan 4, 2021

Be specific. What exact settings do you want to be read-only? I can comment and/or act only on specifics. I consider the issue here solved, you specifically asked for ability to add trusted-site directives to a user's own set, which is what I fixed. For more, open distinct issues for specific settings and what you want about them as admin.

@gorhill gorhill closed this as completed Jan 4, 2021
@gorhill gorhill changed the title Will ublock Origin support more than 1 Admin policies in "chrome://policy" ? Give admins the ability to add trusted sites Jan 4, 2021
@stbeep1
Copy link
Author

stbeep1 commented Jan 4, 2021

Got it. I will create a new issue.

@uBlock-user uBlock-user added the fixed issue has been addressed label Jan 4, 2021
@crimsonmt
Copy link

This functionality would be great, looking forward to implement, currently on version 1.37.2 trying to deploy this via GPO but unsuccessful. Any tricks to getting this push via GPO if at all possible.

@gorhill
Copy link
Member

gorhill commented Aug 11, 2021

@uBlockOrigin uBlockOrigin locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants