Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Vietnamese diacritics #46

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add missing Vietnamese diacritics #46

merged 1 commit into from
Jul 31, 2023

Conversation

huy-vuong
Copy link
Contributor

(See #43.)

@huy-vuong
Copy link
Contributor Author

@tyxla Curious: What was the technical blocker against the master branch from a fork vs. using a feature branch from a fork?

@tyxla
Copy link
Owner

tyxla commented Jul 31, 2023

Thanks for the contribution @huy-vuong!

Curious: What was the technical blocker against the master branch from a fork vs. using a feature branch from a fork?

For some reason, the GitHub UI wasn't allowing me to merge the PR, even though we had fulfilled all the usual requirements (one approval, etc.).

tyxla
tyxla approved these changes Jul 31, 2023
View reviewed changes
Copy link
Owner

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tyxla tyxla merged commit 7bace5c into tyxla:master Jul 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huy-vuong @tyxla