Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Vietnamese diacritics #43

Closed
wants to merge 0 commits into from
Closed

Add missing Vietnamese diacritics #43

wants to merge 0 commits into from

Conversation

huy-vuong
Copy link
Contributor

@huy-vuong huy-vuong commented Mar 22, 2023

Context

  • Source: https://en.wiktionary.org/wiki/%C3%94#See_also_3
    • This section shows a mapping of characters in the alphabet (some of which have diacritics) to characters with additional diacritics. This reflects all possible diacritic combinations in Vietnamese.
    • The diff in this PR adds support for any mappings not already covered in the existing code.
      • This does not include adding any mappings where no diacritics are present, such as the mappings for N.

Testing

  • Tests in test.js updated to include the new mappings and pass.

Copy link
Owner

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huy-vuong, this looks great 👍

🙌

@tyxla
Copy link
Owner

tyxla commented Jul 20, 2023

@huy-vuong just noticed that this PR was opened from your fork's master branch.

Would you mind opening it from a new branch on your fork and reopening a PR?

Thanks in advance!

Copy link
Owner

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, this needs to be on a different branch than master in order to land.

Will also need to be rebased to address merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants