Allow deprecating variants #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDLC01
added
meta
T0mstone
reviewed
Jun 10, 2025
I thought about it, but I think it is easier to just do it manually. Especially if at some point we need a different message for whatever reason. |
laurmaedje
approved these changes
Jun 11, 2025
|
typst/typst#6159 is also merged already, so no blockers on the Typst side. :) |
|
Will get to it tonight |
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows deprecating variants, which I did for the two variants that are already deprecated. I will start working on a corresponding typst/typst PR soon. I may wait until typst/typst#6159 is merged first.
With the current system, there is a weird edge case where modifierless variants can be deprecated independently of the symbol itself, although there is no syntactical way to deprecate a modifierless variant in out DSL. I don't think this is too much of an issue. It could even prove useful if we want to change the default variant of symbol (first, mark the modifierless variant as deprecated, then, in a future version, change its value and remove the deprecation), although this will require adding new syntax at this point.