Skip to content

Rename circle modifier for symbols that are circled to "o" #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Enivex
Copy link
Collaborator

@Enivex Enivex commented May 17, 2025

This is in conflict with #34 . However, circled symbols are extremely common, both in terms of the number of characters (we're still missing a bunch of symbols) and in usage. Therefore, I believe that it deserves its own short and cute modifier, which also has the benefit of resolving the ambiguous conflicting uses of "circle". There is also precedence, in the form of "oo" to mean infinity.

Notes:

  • ast.circle was really a circled variant of ast.op, so I used ast.op.o.
  • circle.nested was really a circled variant of circle.stroked.tiny, so I used circle.stroked.tiny.o
  • The aliases compose.o and convolve.o were missing. I added them

I initially wanted to add additional symbols in this PR, but in the process of looking into this I discovered a number of issues that should ideally be resolved first. I therefore prioritized just getting the ball rolling.

@MDLC01
Copy link
Collaborator

MDLC01 commented May 18, 2025

If circle.stroked.tiny.o is the same as compose.o, maybe we can only keep compose.o. I feel like the .o modifier is less clear in meaning when it comes to geometrical shapes, compared to mathematical operators.

@Enivex
Copy link
Collaborator Author

Enivex commented May 18, 2025

If circle.stroked.tiny.o is the same as compose.o, maybe we can only keep compose.o. I feel like the .o modifier is less clear in meaning when it comes to geometrical shapes, compared to mathematical operators.

I'd be okay with that

@MDLC01 MDLC01 added the breaking This involves a breaking change label May 20, 2025
@MDLC01 MDLC01 requested a review from laurmaedje May 20, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This involves a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants