-
-
Notifications
You must be signed in to change notification settings - Fork 12
Rename circle modifier for symbols that are circled to "o" #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If |
I'd be okay with that |
I did not add a deprecation to slash.circle, since it will likely never see release. |
I'm a bit bugged by the inconsistency of having |
I'd rather go the second route. There's a number of symbols that are currently named with little regard for what they are actually used for. That being said, I'm not sure if that change should be made in this PR or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That being said, I'm not sure if that change should be made in this PR or not.
I think it'd be better to do in another PR then, where we could review other symbols' names.
Yes there is definitely some work to do around geometrical shapes, in the same vein as #28. |
With #86 merged, this can now use the dedicated deprecation syntax for variants. |
Done. I also readded |
What do people feel about renaming It would also aid discoverability. |
It never existed in the firstplace, I don't think there's a point to adding it now when it'd be deprecated anyway. |
Oops, brain fart |
This is in conflict with #34 . However, circled symbols are extremely common, both in terms of the number of characters (we're still missing a bunch of symbols) and in usage. Therefore, I believe that it deserves its own short and cute modifier, which also has the benefit of resolving the ambiguous conflicting uses of "circle". There is also precedence, in the form of "oo" to mean infinity.
Notes:
I initially wanted to add additional symbols in this PR, but in the process of looking into this I discovered a number of issues that should ideally be resolved first. I therefore prioritized just getting the ball rolling.