Skip to content
This repository was archived by the owner on Sep 17, 2023. It is now read-only.

chore: clarify that the internal dependency resolver is exclusive #216

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/make_depend.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ pub fn make_dependency_makefile(opts: crate::opts::MakeDepend) -> Result<()> {
let package_manifest_by_package_name = lerna_manifest.package_manifests_by_package_name()?;

let internal_dependencies_exclusive = package_manifest
.transitive_internal_dependency_package_names(&package_manifest_by_package_name);
.transitive_internal_dependency_package_names_exclusive(&package_manifest_by_package_name);

let internal_dependency_package_json_filenames_inclusive: Vec<PathBuf> = {
let mut dependency_dirs = internal_dependencies_exclusive
Expand Down
2 changes: 1 addition & 1 deletion src/package_manifest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ impl PackageManifest {
.filter_map(|package_name| package_manifests_by_package_name.get(package_name))
}

pub fn transitive_internal_dependency_package_names<'a>(
pub fn transitive_internal_dependency_package_names_exclusive<'a>(
&self,
package_manifest_by_package_name: &'a HashMap<String, PackageManifest>,
) -> Vec<&'a PackageManifest> {
Expand Down
2 changes: 1 addition & 1 deletion src/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ fn query_internal_dependencies(opts: &crate::opts::InternalDependencies) -> Resu
.to_owned(),
};
let values: Vec<String> = package_manifest
.transitive_internal_dependency_package_names(&package_manifest_by_package_name)
.transitive_internal_dependency_package_names_exclusive(&package_manifest_by_package_name)
.into_iter()
.map(|dependency| match opts.format {
opts::InternalDependenciesFormat::Name => {
Expand Down