Skip to content
This repository was archived by the owner on Sep 17, 2023. It is now read-only.

chore: clarify that the internal dependency resolver is exclusive #216

Conversation

bitgopatmcl
Copy link
Contributor

No description provided.

Copy link
Contributor

@EricCrosson EricCrosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bitgopatmcl !

@EricCrosson EricCrosson merged commit d69e5cf into typescript-tools:master Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

🎉 This PR is included in version 4.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@EricCrosson
Copy link
Contributor

@bitgopatmcl This is actually a breaking change, since we're renaming something in the public API. I'll force a release

EricCrosson added a commit that referenced this pull request Dec 8, 2022
This forces a release of #216 under a new major version, since that PR
renames an exported function to more clearly express its behavior.

BREAKING CHANGE: rename `transitive_internal_dependency_package_names`
to `transitive_internal_dependency_package_names_exclusive`.
github-actions bot pushed a commit that referenced this pull request Dec 8, 2022
# [5.0.0](v4.3.5...v5.0.0) (2022-12-08)

* fix!: rename function with _exclusive suffix ([aeb54fe](aeb54fe)), closes [#216](#216)

### BREAKING CHANGES

* rename `transitive_internal_dependency_package_names`
to `transitive_internal_dependency_package_names_exclusive`.
@EricCrosson
Copy link
Contributor

Whoops, this one snuck out as 4.3.5 because of #217!

Since the upgrade path is near-trivial, I don't think it's urgent to revert this diff in the 4.x branch. I'll leave this as a note to any future traveler as a compromise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants