feat(eslint-plugin): [no-base-to-string] check Array.prototype.join

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes [no-base-to-string] add option to prevent usage of Array .join on non-toString things #3388
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	6595fd5
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/673b7bc061acbe00083a25cb
😎 Deploy Preview	https://deploy-preview-10287--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6595fd5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 2 targets

• nx run-many --target=build --exclude website --exclude website-eslint
• nx run-many --target=clean

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (c13b6b4) to head (6595fd5).
Report is 44 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10287      +/-   ##
==========================================
+ Coverage   86.56%   86.72%   +0.15%     
==========================================
  Files         431      434       +3     
  Lines       15188    15246      +58     
  Branches     4418     4446      +28     
==========================================
+ Hits        13148    13222      +74     
+ Misses       1683     1668      -15     
+ Partials      357      356       -1     

Flag	Coverage Δ
unittest	86.72% <100.00%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	98.87% <100.00%> (+3.16%)	⬆️

... and 56 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[Josh-Cena]

IMO: this doesn't have to be an option. I can't think of a case where someone checks all other cases but wants to allow join on purpose.

[yeonjuan]

@Josh-Cena @kirkwaiblinger Thank you for your review. I've fixed it.

[kirkwaiblinger]

I enjoy the fancy abstractions! 😀