Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [max-params] add function overload and function type support #10312

Merged

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

Added support for the TSDeclareFunction and TSFunctionType types.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b22fbbd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6740db3de7dc860008a5a313
😎 Deploy Preview https://deploy-preview-10312--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@developer-bandi developer-bandi marked this pull request as draft November 9, 2024 10:51
@developer-bandi developer-bandi changed the title feat(eslint-plugin): [max-params]: add function overload and function type support feat(eslint-plugin): [max-params] add function overload and function type support Nov 9, 2024
@developer-bandi developer-bandi marked this pull request as ready for review November 9, 2024 11:47
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start 🚀

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 10, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (90aa814) to head (4d7cf19).
Report is 3 commits behind head on main.

Current head 4d7cf19 differs from pull request most recent head b22fbbd

Please upload reports for the commit b22fbbd to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10312      +/-   ##
==========================================
- Coverage   86.69%   86.57%   -0.12%     
==========================================
  Files         434      431       -3     
  Lines       15227    15198      -29     
  Branches     4445     4421      -24     
==========================================
- Hits        13201    13158      -43     
- Misses       1670     1683      +13     
- Partials      356      357       +1     
Flag Coverage Δ
unittest 86.57% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/max-params.ts 94.44% <ø> (ø)

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 looks great to me, thanks as always @developer-bandi!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit cdbc669 into typescript-eslint:main Nov 22, 2024
60 checks passed
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Nov 25, 2024
##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25)

##### 🚀 Features

-   **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287))
-   **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312))

##### ❤️  Thank You

-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Nov 25, 2024
##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25)

##### 🚀 Features

-   **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287))
-   **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312))

##### ❤️  Thank You

-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Nov 26, 2024
##### [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25)

##### 🚀 Features

-   **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287))
-   **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312))

##### ❤️  Thank You

-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Nov 26, 2024
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.15.0 | 8.16.0 |
| npm        | @typescript-eslint/parser        | 8.15.0 | 8.16.0 |


## [v8.16.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8160-2024-11-25)

##### 🚀 Features

-   **eslint-plugin:** \[no-base-to-string] check Array.prototype.join ([#10287](typescript-eslint/typescript-eslint#10287))
-   **eslint-plugin:** \[max-params] add function overload and function type support ([#10312](typescript-eslint/typescript-eslint#10312))

##### ❤️  Thank You

-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [max-params] add option to check overload signatures as well
3 participants