Check bincompat on stuff we should be checking bincompat for #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailuowang
approved these changes
Nov 6, 2019
Contributor
kailuowang
left a comment
kailuowang
left a comment
There was a problem hiding this comment.
thanks very much! assuming build goes green
Contributor
Author
|
(As a side note, you can check this with |
Codecov Report
@@ Coverage Diff @@
## master #3129 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 376 376
Lines 7323 7323
Branches 190 190
=======================================
Hits 6825 6825
Misses 498 498
Continue to review full report at Codecov.
|
rossabaker
approved these changes
Nov 7, 2019
fthomas
approved these changes
Nov 7, 2019
LukaJCB
approved these changes
Nov 7, 2019
ChristopherDavenport
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3109. I've also added bincompat checking (currently against 2.0.0 only) for cats-laws, cats-kernel-laws, cats-testkit, alleycats-core, and alleycats-laws.
One piece of breakage slipped into the 2.13 build in #3099. I've verified that Travis CI fails with just the first two commits.