Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Binary compatibility tests for scala 2.13 #3109

Closed
kailuowang opened this issue Oct 11, 2019 · 5 comments · Fixed by #3129
Closed

Enable Binary compatibility tests for scala 2.13 #3109

kailuowang opened this issue Oct 11, 2019 · 5 comments · Fixed by #3129
Labels
build good first issue Issues that are easier to take on for first time contributors help wanted

Comments

@kailuowang
Copy link
Contributor

This includes binCompatTest as well as mima tests
@kailuowang kailuowang added build good first issue Issues that are easier to take on for first time contributors help wanted labels Oct 11, 2019
@BluePat
Copy link

BluePat commented Oct 26, 2019

Is help still wanted? If it is, I would like to start working on it.
I am a Scala developer, not so experienced with cats. But hey, love the project, one needs to start somewhere.

@kailuowang
Copy link
Contributor Author

Yeah, this is mainly a sbt task, thanks a lot!

@BluePat
Copy link

BluePat commented Oct 27, 2019

In that case, I'm on it.

@travisbrown
Copy link
Contributor

Sorry, @BluePat, but I've gone ahead and done this in a PR I'll be opening in a few minutes, since I was afraid we might have let breaking changes slip through on 2.13 (and I was right 😦).

@travisbrown travisbrown mentioned this issue Nov 6, 2019
Merged
@BluePat
Copy link

BluePat commented Nov 9, 2019

My fault entirely, was to busy to do it ASAP. Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build good first issue Issues that are easier to take on for first time contributors help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check bincompat on stuff we should be checking bincompat for travisbrown/cats
3 participants
@kailuowang @travisbrown @BluePat