Added Bitraverse for Ior (#2144) #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
reviewed
Jan 23, 2018
| implicit val catsBitraverseForIor: Bitraverse[Ior] = new Bitraverse[Ior] { | ||
|
|
||
| def bitraverse[G[_], A, B, C, D](fab: Ior[A, B])(f: A => G[C], g: B => G[D])(implicit G: Applicative[G]): G[Ior[C, D]] = | ||
| fab.fold( |
There was a problem hiding this comment.
Can we replace this fold with an explicit pattern match?
| ) | ||
|
|
||
| def bifoldLeft[A, B, C](fab: Ior[A, B], c: C)(f: (C, A) => C, g: (C, B) => C): C = | ||
| fab.fold(f(c, _), g(c, _), (a, b) => g(f(c, a), b)) |
| fab.fold(f(c, _), g(c, _), (a, b) => g(f(c, a), b)) | ||
|
|
||
| def bifoldRight[A, B, C](fab: Ior[A, B], c: Eval[C])(f: (A, Eval[C]) => Eval[C], g: (B, Eval[C]) => Eval[C]): Eval[C] = | ||
| fab.fold(f(_, c), g(_, c), (a, b) => g(b, f(a, c))) |
V-Lamp
force-pushed
the
bitraverse-for-ior
branch
from
cc411db
to
14de896
Compare
|
Thanks @LukaJCB, done |
kailuowang
approved these changes
Jan 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #2159 +/- ##
==========================================
- Coverage 94.67% 94.64% -0.03%
==========================================
Files 328 328
Lines 5538 5548 +10
Branches 199 213 +14
==========================================
+ Hits 5243 5251 +8
- Misses 295 297 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Bitraverse[Ior], as discussed in #2144For the testing part, I followed the pattern found in for testing
Bitraverse[Either], withincats.tests.EitherSuiteThis is my first PR, let me know if I need do something around this.
...and thanks for all the good work!