Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bitraverse[Ior] #2144

Closed
V-Lamp opened this issue Jan 8, 2018 · 0 comments
Closed

Add Bitraverse[Ior] #2144

V-Lamp opened this issue Jan 8, 2018 · 0 comments

Comments

@V-Lamp
Copy link
Contributor

V-Lamp commented Jan 8, 2018

Hi, I see that there is no Bitraverse instance defined for Ior.

Am I missing something? Is it unlawful maybe? It doesn't look so from plain intuition check :)

I have created one and am happy to contribute it, with tests etc.

Should I just make a PR for this?
V-Lamp added a commit to V-Lamp/cats that referenced this issue Jan 23, 2018
@V-Lamp
Added Bitraverse for Ior (typelevel#2144)
cc411db
@V-Lamp V-Lamp mentioned this issue Jan 23, 2018
Merged
V-Lamp added a commit to V-Lamp/cats that referenced this issue Jan 23, 2018
@V-Lamp
Added Bitraverse for Ior (typelevel#2144)
14de896
LukaJCB pushed a commit that referenced this issue Jan 23, 2018
@V-Lamp
Added Bitraverse for Ior (#2144) (#2159)
a296b8e 
* Added Bitraverse for Ior (#2144)

* Replaced fold with pattern matching
@V-Lamp V-Lamp closed this as completed Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@V-Lamp