Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable mima binary compatibility check for cats-kernel #1483

Merged
merged 1 commit into from
Dec 5, 2016
Merged

enable mima binary compatibility check for cats-kernel #1483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enable mima check
  • Loading branch information
@sritchie-stripe
sritchie-stripe committed Dec 4, 2016
commit 2055bfcf8075e8c5799ad2742e16a84c3283f0e4
13 changes: 10 additions & 3 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ lazy val macros = crossProject.crossType(CrossType.Pure)
lazy val macrosJVM = macros.jvm
lazy val macrosJS = macros.js

val binaryCompatibleVersion = "0.8.0"

lazy val kernel = crossProject.crossType(CrossType.Pure)
.in(file("kernel"))
.settings(moduleName := "cats-kernel", name := "Cats kernel")
Expand All @@ -221,7 +223,13 @@ lazy val kernel = crossProject.crossType(CrossType.Pure)
.settings(sourceGenerators in Compile += (sourceManaged in Compile).map(KernelBoiler.gen).taskValue)
.settings(includeGeneratedSrc)
.jsSettings(commonJsSettings:_*)
.jvmSettings((commonJvmSettings ++ (mimaPreviousArtifacts := Set("org.typelevel" %% "cats-kernel" % "0.7.0"))):_*)
.jvmSettings((commonJvmSettings ++
(mimaPreviousArtifacts := {
if (scalaVersion.value startsWith "2.12")
Set()
else
Set("org.typelevel" %% "cats-kernel" % binaryCompatibleVersion)
})):_*)

lazy val kernelJVM = kernel.jvm
lazy val kernelJS = kernel.js
Expand Down Expand Up @@ -409,7 +417,7 @@ lazy val publishSettings = Seq(
// These aliases serialise the build for the benefit of Travis-CI.
addCommandAlias("buildJVM", "catsJVM/test")

addCommandAlias("validateJVM", ";scalastyle;buildJVM;makeMicrosite")
addCommandAlias("validateJVM", ";scalastyle;buildJVM;mimaReportBinaryIssues;makeMicrosite")

addCommandAlias("validateJS", ";catsJS/compile;testsJS/test;js/test")

Expand Down Expand Up @@ -569,4 +577,3 @@ lazy val update2_12 = Seq(
}
}
)

2 changes: 1 addition & 1 deletion project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.3.3")
addSbtPlugin("com.github.gseitz" % "sbt-release" % "1.0.3")
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.0.0")
addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.1.11")
addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.1.12")
addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.5.3")
addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.2.16")
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "0.8.0")
Expand Down
2 changes: 1 addition & 1 deletion scripts/travis-publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ js="$sbt_cmd validateJS"
kernel_js="$sbt_cmd validateKernelJS"
free_js="$sbt_cmd validateFreeJS"
jvm="$sbt_cmd coverage validateJVM coverageReport && codecov"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace change from my editor

run_cmd="$js && $free_js && $kernel_js && $jvm && $sbt_cmd $publish_cmd"

eval $run_cmd