enable mima binary compatibility check for cats-kernel #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
commented
Dec 4, 2016
| @@ -31,7 +31,7 @@ js="$sbt_cmd validateJS" | |||
| kernel_js="$sbt_cmd validateKernelJS" | |||
| free_js="$sbt_cmd validateFreeJS" | |||
| jvm="$sbt_cmd coverage validateJVM coverageReport && codecov" | |||
|
|
|||
There was a problem hiding this comment.
whitespace change from my editor
Current coverage is 91.93% (diff: 100%)@@ master #1483 diff @@
==========================================
Files 242 243 +1
Lines 3609 3620 +11
Methods 3540 3502 -38
Messages 0 0
Branches 69 118 +49
==========================================
Hits 3328 3328
- Misses 281 292 +11
Partials 0 0
|
|
👍 |
|
this was there in the past, got removed because we wanted to fix something, but now that spire and algebird depend on kernel, we need to get this locked down and work around with binary compatible changes in the future (for kernel at least). |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't running. I added the command to
validateJVM.Once we publish a 2.12 version we'll want to remove my switch that excludes mima for the 2.12 build - anything that changes should get caught in the meantime.
I'll also make a strong push for enabling this plugin for more of our modules, and being okay with minor version bumps if we do want to move fast. Life's tough downstream when you can't trust the version number.