Skip to content

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Jul 14, 2016

This shouldn't be merged until version 0.6.1 is released.

Currently I don't have permission to publish to Sonatype for cats, so for now I'm hoping that @non (or someone else -- maybe @travisbrown or @kailuowang or @mpilquist ?) can publish the release (off of the series/0.6.x branch). Hopefully by the time we are ready for the next release I can get the necessary permissions. I've guessed Saturday as the release date in the changelog but we can definitely change that depending on when it actually gets released :)

Note: there's a little bit of strangeness in that we need to make these changes to the master branch since that's the README that people see, but it kind of seems like these changes should also live on the series/0.6.x branch. However, the 0.6.x branch was made off of the v0.6.0 tag which doesn't actually include the release notes for the 0.6.0 release. I'm inclined to not worry about updating the documentation on the 0.6.0 branch and just make a manual adjustment to the suggested version number in index.md on the gh-pages branch. Hopefully we can form a better system for the next release.

@codecov-io
Copy link

codecov-io commented Jul 14, 2016

Current coverage is 89.16%

Merging #1196 into master will not change coverage

@@             master      #1196   diff @@
==========================================
  Files           234        234          
  Lines          3137       3137          
  Methods        3083       3083          
  Messages          0          0          
  Branches         52         52          
==========================================
  Hits           2797       2797          
  Misses          340        340          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 556e97b...b841efc

@kailuowang
Copy link
Contributor

kailuowang commented Jul 14, 2016

👍 thanks @ceedubs. I think I have the permission to release cats on sonatype, but I've never released cats before. Is it just a sbt release from the series/0.6.x branch? Any other manual step?

@travisbrown
Copy link
Contributor

I also don't have publishing permissions, but 👍 to @kailuowang running it.

@ceedubs
Copy link
Contributor Author

ceedubs commented Jul 14, 2016

@kailuowang I haven't released either. There are instructions here (but as you mentioned it should be from the series/0.6.x branch). Hopefully they are right :P

@kailuowang
Copy link
Contributor

@ceedubs okay I am going to give it shot. Will ask in gitter as well.

@@ -1,3 +1,17 @@
## Version 0.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this change the name of many implicits? Should we mention that and mention that it is not strictly binary compatible with 0.6.1 due to that change?

Also, why not 0.7.0 to signify that change rather than 0.6.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnynek this isn't a release of the current master. It's just a backport to the series/0.6.x branch that should be equivalent to 0.6.0 but with the addition of #1173.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more notes:

It should be completely binary compatible (as verified by mima).

It's a little strange that the CHANGES.md PR is to the master branch. See the note in the original PR message about the current branch/release system being a little cumbersome. I'm hoping we can have a good system for this in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. Thanks for the clarification!

@kailuowang
Copy link
Contributor

kailuowang commented Jul 14, 2016

@ceedubs, do you mind update the release date?

@ceedubs
Copy link
Contributor Author

ceedubs commented Jul 14, 2016

@kailuowang thanks for the reminder. Release date updated.

@kailuowang
Copy link
Contributor

👍

@ceedubs
Copy link
Contributor Author

ceedubs commented Jul 14, 2016

I'm just going to merge since the only thing that changed in the last commit was the release date in the CHANGES.md file.

@ceedubs ceedubs merged commit 5455ff1 into typelevel:master Jul 14, 2016
@ceedubs ceedubs deleted the release-notes-0.6.1 branch July 14, 2016 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants