Skip to content

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Jul 1, 2016

This PR (which is against the series/0.6.x branch that I just created) does a couple of things:

I will largely unavailable for a little over a week, but I thought that if I got this branch set up someone else (@non?) might be able to get a 0.6.1 published with the fix for this pretty nasty bug.

cc @mpilquist and @travisbrown who have both expressed interest in getting this backported for a 0.6.1 release.

@travisbrown
Copy link
Contributor

Thanks, @ceedubs! This looks good to me.

@non
Copy link
Contributor

non commented Jul 4, 2016

👍

@kailuowang
Copy link
Contributor

kailuowang commented Jul 6, 2016

👍 Thanks @ceedubs

@kailuowang
Copy link
Contributor

kailuowang commented Jul 6, 2016

I checked out the code on my machine, the mimaReportBinaryIssues, when run under root project, simply crashes with exit code 255 and without any error output just like on travis, but if I run it under project coreJVM you get the following error. So somehow the released 0.6.0 binary is somewhere before this commit:
a77beec
(which is in the 0.6.0 tag), or mima pulled down a different binary?

[info] core: found 8 potential binary incompatibilities while checking against org.typelevel:cats-core_2.11:0.6.0
[error] * the type hierarchy of object cats.implicits is different in current version. Missing types {cats.syntax.ApplicativeErrorSyntax1}
[error] filter with: ProblemFilters.excludeMissingTypesProblem
[error] * the type hierarchy of trait cats.syntax.ApplicativeErrorSyntax is different in current version. Missing types {cats.syntax.ApplicativeErrorSyntax1}
[error] filter with: ProblemFilters.excludeMissingTypesProblem
[error] * trait cats.syntax.ApplicativeErrorSyntax1 does not have a correspondent in current version
[error] filter with: ProblemFilters.excludeMissingClassProblem
[error] * the type hierarchy of interface cats.syntax.AllSyntax is different in current version. Missing types {cats.syntax.ApplicativeErrorSyntax1}
[error] filter with: ProblemFilters.excludeMissingTypesProblem
[error] * method combine(cats.data.XorT,cats.Apply,cats.kernel.Semigroup,cats.kernel.Semigroup)cats.data.XorT in class cats.data.XorT does not have a correspondent in current version
[error] filter with: ProblemFilters.excludeDirectMissingMethodProblem
[error] * method xorMonoid(cats.kernel.Semigroup,cats.kernel.Monoid)cats.kernel.Monoid in class cats.data.XorInstances does not have a correspondent in current version
[error] filter with: ProblemFilters.excludeDirectMissingMethodProblem
[error] * method combine(cats.data.Xor,cats.kernel.Semigroup,cats.kernel.Semigroup)cats.data.Xor in class cats.data.Xor does not have a correspondent in current version
[error] filter with: ProblemFilters.excludeDirectMissingMethodProblem
[error] * method xorSemigroup(cats.kernel.Semigroup,cats.kernel.Semigroup)cats.kernel.Semigroup in class cats.data.XorInstances1 does not have a correspondent in current version
[error] filter with: ProblemFilters.excludeDirectMissingMethodProblem
[trace] Stack trace suppressed: run last coreJVM/*:mimaReportBinaryIssues for the full output.
error core: Binary compatibility check failed!
[error] Total time: 1 s, completed Jul 6, 2016 5:36:08 PM

@ceedubs
Copy link
Contributor Author

ceedubs commented Jul 13, 2016

@kailuowang thanks for investigating this. I was on vacation, but I'm back now and will try to follow up on this.

@codecov-io
Copy link

Current coverage is 88.07%

Merging #1173 into series/0.6.x will decrease coverage by 0.55%

@@           series/0.6.x      #1173   diff @@
==============================================
  Files               214        214          
  Lines              2717       2717          
  Methods            2662       2656     -6   
  Messages              0          0          
  Branches             50         56     +6   
==============================================
- Hits               2408       2393    -15   
- Misses              309        324    +15   
  Partials              0          0          

Sunburst

Powered by Codecov. Last updated by 207fda4...e8b7ce4

@ceedubs
Copy link
Contributor Author

ceedubs commented Jul 14, 2016

Okay the build issue seems to be fixed with e8b7ce4

@kailuowang I couldn't reproduce the compatibility issue that you showed. Is it possible that you have a locally-published version of cats 0.6 that mima is picking up?

I think this is probably ready to merge, but I think I'll need help from @non or someone else who can publish to get this out there. At some point I should probably get set up to be able to publish to Sonatype for cats.

@kailuowang
Copy link
Contributor

@ceedubs ah that might be the case, I do have a local cats 0.6 😊
Sorry about the confusion.
This LGTM 👍

@ceedubs ceedubs merged commit b6010db into typelevel:series/0.6.x Jul 14, 2016
@ceedubs ceedubs deleted the backport-tuple-order-fix branch July 14, 2016 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants