-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Backport tuple order fix for 0.6.x #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport tuple order fix for 0.6.x #1173
Conversation
… only the first element was used in comparisons
Thanks, @ceedubs! This looks good to me. |
👍 |
👍 Thanks @ceedubs |
I checked out the code on my machine, the
|
@kailuowang thanks for investigating this. I was on vacation, but I'm back now and will try to follow up on this. |
Current coverage is 88.07%
@@ series/0.6.x #1173 diff @@
==============================================
Files 214 214
Lines 2717 2717
Methods 2662 2656 -6
Messages 0 0
Branches 50 56 +6
==============================================
- Hits 2408 2393 -15
- Misses 309 324 +15
Partials 0 0
|
Okay the build issue seems to be fixed with e8b7ce4 @kailuowang I couldn't reproduce the compatibility issue that you showed. Is it possible that you have a locally-published version of cats 0.6 that mima is picking up? I think this is probably ready to merge, but I think I'll need help from @non or someone else who can publish to get this out there. At some point I should probably get set up to be able to publish to Sonatype for cats. |
@ceedubs ah that might be the case, I do have a local cats 0.6 😊 |
This PR (which is against the
series/0.6.x
branch that I just created) does a couple of things:I will largely unavailable for a little over a week, but I thought that if I got this branch set up someone else (@non?) might be able to get a 0.6.1 published with the fix for this pretty nasty bug.
cc @mpilquist and @travisbrown who have both expressed interest in getting this backported for a 0.6.1 release.