Fix a crash on mypy master branch #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python/mypy#18818 the `msg` argument to `analyze_member_access()` was removed.
|
@sobolevn Perhaps we should also check mypy master in CI? |
ngnpope
commented
May 9, 2025
|
|
||
| # TODO: [mypy 1.16+] Remove this workaround for passing `msg` to `analyze_member_access()`. | ||
| extra: dict[str, Any] = {} | ||
| if "msg" in inspect.signature(analyze_member_access).parameters: # mypy < 1.16 |
There was a problem hiding this comment.
Bummer. Looks like inspect.signature() won't work because of mypyc...
ValueError: no signature found for builtin <built-in function analyze_member_access>
ngnpope
commented
May 9, 2025
|
|
||
| from mypy_django_plugin.lib import helpers | ||
|
|
||
| mypy_version_info = tuple(map(int, mypy_version.partition("+")[0].split("."))) |
There was a problem hiding this comment.
Switched to a version-based check. This is somewhat ugly, but I didn't want to add packaging as a dependency.
sobolevn
approved these changes
May 9, 2025
|
mypy 1.16 released now, will django-stubs cut a corresponding release with this fix soon? |
|
yes! |
4 tasks
asottile-sentry
pushed a commit
to getsentry/sentry-forked-django-stubs
that referenced
this pull request
Jun 3, 2025
* Fix a crash on mypy master branch In python/mypy#18818 the `msg` argument to `analyze_member_access()` was removed. * Switch to using a version-based check
asottile-sentry
added a commit
to getsentry/sentry-forked-django-stubs
that referenced
this pull request
Jun 3, 2025
cherry-picked from typeddjango#2670 Co-authored-by: Nick Pope <nick@nickpope.me.uk>
jose-reveni
pushed a commit
to jose-reveni/django-stubs
that referenced
this pull request
Jun 9, 2025
* Fix a crash on mypy master branch In python/mypy#18818 the `msg` argument to `analyze_member_access()` was removed. * Switch to using a version-based check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
In python/mypy#18818 the
msgargument toanalyze_member_access()was removed.This will crash when mypy v1.16 gets released, so only pass
msgif it is in the function signature.Related issues
N/A