Skip to content

Update plugin to support mypy 1.16.0 #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Jazzinghen
Copy link

@Jazzinghen Jazzinghen commented May 30, 2025

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #2148

I have not updated the readme as there is no strict reference to the supported mypy version, and it looks like the changelog contains release info, so I didn't touch that one either.

All the checks passed, even though I had to add an ignore flag in a function that was using some strange trait-based property access.

I used a solution very similar to the one used in typeddjango/django-stubs#2670 but I get the version info using importlib instead of the string in the module.

@Jazzinghen
Copy link
Author

This is strange. I haven't seen these issues on my side. 🤔

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You updated

name = "wemake-python-styleguide"
version = "1.1.0"

Let's pin it to 1.0 for now :)

@Jazzinghen
Copy link
Author

Oh? I didn't notice. I think I might have just ran poetry update -U to get the latest version of Mypy and that updated everything in the lock file. Should I change the entry in pyproject.toml to limit the version to 1.0?

@sobolevn
Copy link
Member

sobolevn commented Jun 2, 2025

yes, please :)

@Jazzinghen
Copy link
Author

Rebased against master and pinned version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Returns mypy plugin crashes with mypy 1.16
2 participants