Allow StampWithIjar to use default shell env #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the detailed description! I would be a lot more apprehensive of the change without it. |
|
Could you use the actions.run environment to set this with a select()-able config value which changes the value of LD_LIBRARY_PATH in the environment based on the platform. I think that might be a better solution than having to pass --action_env which will effect all actions in the build which use_default_shell_env=True. |
|
@hrfuller could you expand on an example of what that would look like? I'm not familiar with that functionality |
This was referenced Feb 26, 2021
wisechengyi
pushed a commit
that referenced
this pull request
Mar 2, 2021
### Description Originally it was unknown to me that we could use flags to directly disable the stamping of scala imports using `build --@io_bazel_rules_scala//scala/settings:stamp_scala_import=False` in the `.bazelrc` file. Discussion in bazelbuild#1232 cleared that up. ### Motivation Reverting #8 as it is not needed.
cattibrie
pushed a commit
that referenced
this pull request
Mar 9, 2021
### Description Originally it was unknown to me that we could use flags to directly disable the stamping of scala imports using `build --@io_bazel_rules_scala//scala/settings:stamp_scala_import=False` in the `.bazelrc` file. Discussion in bazelbuild#1232 cleared that up. ### Motivation Reverting #8 as it is not needed.
cattibrie
pushed a commit
that referenced
this pull request
Mar 11, 2021
### Description Originally it was unknown to me that we could use flags to directly disable the stamping of scala imports using `build --@io_bazel_rules_scala//scala/settings:stamp_scala_import=False` in the `.bazelrc` file. Discussion in bazelbuild#1232 cleared that up. ### Motivation Reverting #8 as it is not needed.
adam-singer
added a commit
that referenced
this pull request
Oct 5, 2021
### Description Originally it was unknown to me that we could use flags to directly disable the stamping of scala imports using `build --@io_bazel_rules_scala//scala/settings:stamp_scala_import=False` in the `.bazelrc` file. Discussion in bazelbuild#1232 cleared that up. ### Motivation Reverting #8 as it is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When action
StampWithIjarruns it does not allow environment variables to be passed in using--action_envcommand line flag. This can lead to problems whenijaris executed on systems that have compiled it with a tool chain picked up from the environment but not available on the host system in standard locations.The difference with this change is when
build --action_env=LD_LIBRARY_PATHor any other--action_envenv flag is passed it will be threaded into the rules_scala action command environment forStampWithIjar.Motivation
Tool chains that are picked up from the environment on a host are used to compile native code, but that host does not have proper libc libraries to support execution without knowing
LD_LIBRARY_PATHwhere shared libraries exist that do contain symbols compiled against.