[revert] use_default_shell_env = True #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisechengyi
approved these changes
Mar 2, 2021
cattibrie
pushed a commit
that referenced
this pull request
Mar 9, 2021
### Description Originally it was unknown to me that we could use flags to directly disable the stamping of scala imports using `build --@io_bazel_rules_scala//scala/settings:stamp_scala_import=False` in the `.bazelrc` file. Discussion in bazelbuild#1232 cleared that up. ### Motivation Reverting #8 as it is not needed.
cattibrie
pushed a commit
that referenced
this pull request
Mar 11, 2021
### Description Originally it was unknown to me that we could use flags to directly disable the stamping of scala imports using `build --@io_bazel_rules_scala//scala/settings:stamp_scala_import=False` in the `.bazelrc` file. Discussion in bazelbuild#1232 cleared that up. ### Motivation Reverting #8 as it is not needed.
adam-singer
added a commit
that referenced
this pull request
Oct 5, 2021
### Description Originally it was unknown to me that we could use flags to directly disable the stamping of scala imports using `build --@io_bazel_rules_scala//scala/settings:stamp_scala_import=False` in the `.bazelrc` file. Discussion in bazelbuild#1232 cleared that up. ### Motivation Reverting #8 as it is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally it was unknown to me that we could use flags to directly disable the stamping of scala imports using
build --@io_bazel_rules_scala//scala/settings:stamp_scala_import=Falsein the.bazelrcfile. Discussion inbazelbuild#1232 cleared that up.
Motivation
Reverting #8 as it is not needed.