Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getSettings instead of getCapabilities to fix FF error #526

Merged
merged 1 commit into from
May 21, 2021
Merged

Use getSettings instead of getCapabilities to fix FF error #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/__mocks__/twilio-video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const mockRoom = new MockRoom();
class MockTrack extends EventEmitter {
kind = '';
stop = jest.fn();
mediaStreamTrack = { getCapabilities: () => ({ deviceId: 'mockDeviceId' }) };
mediaStreamTrack = { getSettings: () => ({ deviceId: 'mockDeviceId' }) };

constructor(kind: string) {
super();
Expand Down
2 changes: 1 addition & 1 deletion src/components/VideoProvider/useLocalTracks/useLocalTracks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export default function useLocalTracks() {
// in cases where the user's video is disabled.
window.localStorage.setItem(
SELECTED_VIDEO_INPUT_KEY,
newVideoTrack.mediaStreamTrack.getCapabilities().deviceId ?? ''
newVideoTrack.mediaStreamTrack.getSettings().deviceId ?? ''
);
}
if (newAudioTrack) {
Expand Down