Use getSettings instead of getCapabilities to fix FF error #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR fixes an issue where users are unable to acquire audio in Firefox due to an error.
This PR removes the usage of
mediaStreamStrack.getCapabilities()
and replaces it withmediaStreamStrack.getSettings()
. These functions are used to get the deviceID after a camera track is acquired.The error was due to the fact that
getCapabilities()
is not supported in Firefox. See the following browser compatibility tables:https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/getSettings
https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/getCapabilities
This PR works in desktop and mobile versions of Chrome, Firefox, and Safari.
Burndown
Before review
npm test
Before merge