Skip to content

Conversation

@dkundel
Copy link
Contributor

@dkundel dkundel commented Apr 16, 2021

We wrap error events from the API/Got into a dedicated class. The URL helps support to debug issues
but wasn't in the debug logs since this change. This commit adds the URL back

fix #167

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

We wrap error events from the API/Got into a dedicated class. The URL helps support to debug issues
but wasn't in the debug logs since this change. This commit adds the URL back

fix #167
@dkundel dkundel changed the title improvement(serverless-api): add request url to API error logs fix(serverless-api): add request url to API error logs Apr 16, 2021
Copy link
Contributor

@philnash philnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dkundel dkundel merged commit 4e79890 into main Apr 20, 2021
@dkundel dkundel deleted the dkundel/fix-167 branch April 20, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug Logs should show failed URL

3 participants