Debug Logs should show failed URL

[adamchasetaylor]

When uploading an asset, I noticed that the deployment was failing. I tried to check the debug logs and noticed that the URL is not exposed.

To duplicate:

twilio serverless:init
add in a large asset (above 25MB) in the assets folder
twilio serverless:deploy --force -l debug

⠇ Creating 1 Assets
⠙ Uploading 1 Assets
twilio-serverless-api:assets { HTTPError: Response code 413 (Request Entity Too Large)
twilio-serverless-api:assets at /Users/adtaylor/.twilio-cli/node_modules/twilio-run/node_modules/@twilio-labs/serverless-api/dist/api/assets.js:127:23
twilio-serverless-api:assets at Generator.throw ()
twilio-serverless-api:assets at rejected (/Users/adtaylor/.twilio-cli/node_modules/twilio-run/node_modules/@twilio-labs/serverless-api/dist/api/assets.js:7:65)
twilio-serverless-api:assets at process._tickCallback (internal/process/next_tick.js:68:7) name: 'HTTPError', code: undefined } +269ms
twilio-run:deploy Error: Failed to upload Asset /hold.mp3
twilio-run:deploy at /Users/adtaylor/.twilio-cli/node_modules/twilio-run/node_modules/@twilio-labs/serverless-api/dist/api/assets.js:128:19
twilio-run:deploy at Generator.throw ()
twilio-run:deploy at rejected (/Users/adtaylor/.twilio-cli/node_modules/twilio-run/node_modules/@twilio-labs/serverless-api/dist/api/assets.js:7:65)

Expectation:

I would see that the error code was being thrown for the serverless-upload url

[philnash]

Is the following line not enough? What would you expect to see?

twilio-run:deploy Error: Failed to upload Asset /hold.mp3

[dkundel]

I asked Adam to file this. When I cleaned up the debug logs to avoid leaking sensitive information into debug logs, one thing that disappeared was the actual underlying Request URL. I think it's worth to log in the debug logs the actual API endpoint URLs we are calling. This can help others at Twilio to better detect where something is failing for a customer.

[philnash]

Ah, fair enough.

[welcome]

Thank you so much for opening your first issue in this project! We'll try to get back to it as quickly as possible. While you are waiting...here's a random picture of a corgi (powered by dog.ceo)