refactor(http)!: replace ListBody with Vec
#2096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilgotf
force-pushed
the
vilgotf/refactor/http/listbody
branch
3 times, most recently
from
3ba4b42
to
1c39ed1
Compare
|
I would like to do some thinking about this marker, so I would like to hold this for after 0.15 so we have time to do so. |
vilgotf
force-pushed
the
vilgotf/refactor/http/listbody
branch
from
1c39ed1
to
ea2eb61
Compare
vilgotf
force-pushed
the
vilgotf/refactor/http/listbody
branch
from
ea2eb61
to
c9f13f0
Compare
Gelbpunkt
requested changes
Jan 26, 2024
| pub fn models(self) -> ModelFuture<Vec<T>> { | ||
| Response::<Vec<T>>::new(self.inner).model() | ||
| /// response body could not be deserialized into the target model. | ||
| #[deprecated(since = "0.15.0", note = "use `model` instead")] |
There was a problem hiding this comment.
just drop this entirely since it's targeting next
|
Let's try something fun instead of giving on up the current API: #2310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's no need for any special
Vec<T>handling, this PR removes theListBody<T>marker type.Together with #2083 this PR leaves only the
EmptyBodymarker, after which themarkermodule could become private, exportingEmptyBodydirectly in therequestmodule.Somewhat dependent upon #2083
TODO
modelsmethod notifying users to switching tomodel