refactor(model, http, cache)!: remove guild_id from members #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-cache
vilgotf
changed the title
suneettipirneni
force-pushed
the
refactor/members/remove-guildId
branch
from
22957bb
to
12d066f
Compare
vilgotf
requested changes
Jan 20, 2023
suneettipirneni
force-pushed
the
refactor/members/remove-guildId
branch
from
bc201f8
to
b503ef1
Compare
vilgotf
requested changes
Jan 22, 2023
suneettipirneni
force-pushed
the
refactor/members/remove-guildId
branch
from
fd964c5
to
eced9f0
Compare
suneettipirneni
force-pushed
the
refactor/members/remove-guildId
branch
from
df94638
to
b5e7ce6
Compare
vilgotf
previously requested changes
Jan 23, 2023
vilgotf
reviewed
Jan 23, 2023
suneettipirneni
changed the title
zeylahellyer
approved these changes
Jan 25, 2023
|
Manually ran this and received some member add events and it works as expected |
vilgotf
approved these changes
Jan 26, 2023
Comment on lines
15
to
27
| impl Deref for MemberAdd { | ||
| type Target = Member; | ||
|
|
||
| fn deref(&self) -> &Self::Target { | ||
| &self.0 | ||
| &self.member | ||
| } | ||
| } | ||
|
|
||
| impl DerefMut for MemberAdd { | ||
| fn deref_mut(&mut self) -> &mut Self::Target { | ||
| &mut self.0 | ||
| &mut self.member | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this is confusing and I don't think we do this for any other struct with multiple items. Should it really be preserved? cc @zeylahellyer
There was a problem hiding this comment.
It may technically not be idiomatic, but we should avoid breaking even more here. We can iterate on it if needed in the next major version
1 task
Erk-
approved these changes
Jan 28, 2023
|
Thanks for the PR! |
zeylahellyer
added a commit
that referenced
this pull request
Feb 5, 2023
Remove a link to the `member` module from the `guild` module-level documentation. This link should have been removed in pull request #2083 but was missed.
zeylahellyer
added a commit
that referenced
this pull request
Feb 5, 2023
Remove a link to the `member` module from the `guild` module-level documentation. This link should have been removed in pull request #2083 but was missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2082
In addition to the titular change, this PR removes the following structures:
MemberIntermediateMemberListBodyMemberBodyMemberListDeserializerMemberDeserializerOther changes:
MEMBER_ADDtheguild_idis attached to the event tuple.cache-inmemory'smember_rolespermission helper now takes another required parameter for the guild id.