Skip to content

Commit

Permalink
Linter tweaks for ampproject#15444
Browse files Browse the repository at this point in the history
  • Loading branch information
twifkak committed May 21, 2018
1 parent acb2cdf commit eb639c9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions validator/engine/parse-url_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,8 @@ describe('parse_url', () => {
assertStrictEqual('', url.host);
});

it('rejects http:/// (empty host)', () => {
const urlString = 'http:///';
it('rejects http:/// (empty host)', () => { // NOTYPO
const urlString = 'http:///'; // NOTYPO
const url = new parse_url.URL(urlString);
assertStrictEqual(false, url.isValid);
assertStrictEqual('', url.host);
Expand Down
2 changes: 1 addition & 1 deletion validator/engine/validator.js
Original file line number Diff line number Diff line change
Expand Up @@ -3578,7 +3578,7 @@ function checkForReferencePointCollision(
function validateAncestorTags(parsedTagSpec, context, validationResult) {
const spec = parsedTagSpec.getSpec();
if (spec.mandatoryAncestor !== null) {
const {mandatoryAncestor} = spec;
const mandatoryAncestor = /** @type {string} */ (spec.mandatoryAncestor);
if (!context.getTagStack().hasAncestor(mandatoryAncestor)) {
if (amp.validator.LIGHT) {
validationResult.status = amp.validator.ValidationResult.Status.FAIL;
Expand Down

0 comments on commit eb639c9

Please sign in to comment.