Test allowed_protocol:http and !allow_relative:false

twifkak · May 21, 2018 · acb2cdf · acb2cdf
1 parent 5b32b6b
commit acb2cdf
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/validator/engine/validator_test.js b/validator/engine/validator_test.js
@@ -657,6 +657,20 @@ function attrRuleShouldMakeSense(attrSpec, rules) {
         }
       });
     }
+    // If allowed_protocol is http then allow_relative should not be false
+    // except for `data-` attributes.
+    if (!attrSpec.name.startsWith('data-')) {
+      for (const allowedProtocol of attrSpec.valueUrl.allowedProtocol) {
+        if ((allowedProtocol === 'http') &&
+            (attrSpec.valueUrl.allowRelative !== null)) {
+          it('allow_relative can not be false if allowed_protocol is http: ' +
+                 attrSpec.name,
+             () => {
+               expect(attrSpec.valueUrl.allowRelative).toEqual(true);
+             });
+        }
+      }
+    }
   }
   if (attrSpec.valueRegex !== null) {
     it('value_regex valid', () => {